RE: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug report
From: Xu, Even
Date: Wed Mar 26 2025 - 20:59:13 EST
Hi, David,
Thanks for reminder!
This issue already had patch fix at 2/13: https://lore.kernel.org/linux-input/20250213024021.2477473-1-even.xu@xxxxxxxxx/
Hi, Jiri,
I didn't find this patch in latest v6.14-rc7, would you mind help double check which branch this patch got applied?
Thanks!
Best Regards,
Even Xu
> -----Original Message-----
> From: David Binderman <dcb314@xxxxxxxxxxx>
> Sent: Thursday, March 27, 2025 3:16 AM
> To: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>;
> jikos@xxxxxxxxxx; bentiss@xxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c bug report
>
> Hello there,
>
> Static analyser cppcheck says:
>
> linux-6.14/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:24: style:
> Boolean result is used in bitwise operation. Clarify expression with parentheses.
> [clarifyCondition]
>
> Source code is
>
> if (!config->sgls[i] | !config->sgls_nent[i])
>
> Perhaps || was intended instead of | ?
>
> Regards
>
> David Binderman
>