Re: [GIT PULL] selinux/selinux-pr-20250323

[Linus Torvalds]

On Wed, 26 Mar 2025 at 20:28, Thiébaud Weksteen <tweek@xxxxxxxxxx> wrote:
>
> That is not quite right. If you look at commit 581dd6983034 [1], when
> a firmware is about to be loaded, the kernel credentials are used.

Ahh, that's good, at least there's no "random state" to check.

But it does still mean that the security check is pointless - there
aren't any other credentials that would validly be used for firmware
loading, so what was the point of checking them again?

In fact, the commit you point to was made exactly *because* the kind
of pointless and wrong security checks that I'm complaining about were
done, wasn't it?

                    Linus