Re: [PATCH] input: atkbd: do not init atkbd_reset variable to true on Loongson

From: Huacai Chen
Date: Thu Mar 27 2025 - 00:17:34 EST


Hi, Qunqin,

On Thu, Mar 27, 2025 at 10:58 AM Qunqin Zhao <zhaoqunqin@xxxxxxxxxxx> wrote:
>
> The keyboard will not be confused on Loongson platform, so do not need a
> full reset of the keyboard.
>
> Signed-off-by: Qunqin Zhao <zhaoqunqin@xxxxxxxxxxx>
> ---
> drivers/input/keyboard/atkbd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index adf0f31199..f8ef3e929a 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -37,7 +37,8 @@ static int atkbd_set = 2;
> module_param_named(set, atkbd_set, int, 0);
> MODULE_PARM_DESC(set, "Select keyboard code set (2 = default, 3 = PS/2 native)");
>
> -#if defined(__i386__) || defined(__x86_64__) || defined(__hppa__)
> +#if defined(__i386__) || defined(__x86_64__) || defined(__hppa__) || \
> + defined(__loongarch__)
No new line is needed, now there is no 80 columns limit.
Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>


Huacai

> static bool atkbd_reset;
> #else
> static bool atkbd_reset = true;
> --
> 2.45.2
>