Re: [PATCH] f2fs: prevent the current section from being selected as a victim during garbage collection

From: Chao Yu
Date: Thu Mar 27 2025 - 02:02:13 EST


On 3/26/25 22:14, Yohan Joung wrote:
> When selecting a victim using next_victim_seg in a large section, the
> selected section might already have been cleared and designated as the
> new current section, making it actively in use.
> This behavior causes inconsistency between the SIT and SSA.

Hi, does this fix your issue?

https://lore.kernel.org/linux-f2fs-devel/20250325080646.3291947-2-chao@xxxxxxxxxx

Thanks,

>
> Signed-off-by: Yohan Joung <yohan.joung@xxxxxx>
> ---
> fs/f2fs/gc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 2b8f9239bede..4b5d18e395eb 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1926,6 +1926,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control)
> goto stop;
> }
>
> + if (__is_large_section(sbi) &&
> + IS_CURSEC(sbi, GET_SEC_FROM_SEG(sbi, segno)))
> + goto stop;
> +
> seg_freed = do_garbage_collect(sbi, segno, &gc_list, gc_type,
> gc_control->should_migrate_blocks,
> gc_control->one_time);