Re: [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767

[Bartosz Golaszewski]

On Thu, Mar 27, 2025 at 1:50 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:
>
> From: Peng Fan <peng.fan@xxxxxxx>
>
> This is prepare patch for switching s5m8767 regulator driver to
> use GPIO descriptor. DTS for exynos5250 spring incorrectly specifies
> "active low" polarity for the DVS and DS line. But per datasheet,
> they are actually active high. So add polarity quirk for it.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>
> V2:
>  New patch
>
>  drivers/gpio/gpiolib-of.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index eb667f8f1ead..83559dd24f32 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -222,6 +222,15 @@ static void of_gpio_try_fixup_polarity(const struct device_node *np,
>                  */
>                 { "lantiq,pci-xway",    "gpio-reset",   false },
>  #endif
> +#if IS_ENABLED(CONFIG_REGULATOR_S5M8767)
> +               /*
> +                * According to S5M8767, the DVS and DS pin are
> +                * active-high signals. However, exynos5250-spring.dts use
> +                * active-low setting.
> +                */
> +               { "samsung,s5m8767-pmic", "s5m8767,pmic-buck-dvs-gpios", true },
> +               { "samsung,s5m8767-pmic", "s5m8767,pmic-buck-ds-gpios", true },
> +#endif
>  #if IS_ENABLED(CONFIG_TOUCHSCREEN_TSC2005)
>                 /*
>                  * DTS for Nokia N900 incorrectly specified "active high"
> --
> 2.37.1
>

Mark,

Once v6.15-rc1 is tagged, I'd like to pick it up and provide you with
an immutable tag so that you can take the corresponding regulator
patch through your tree, does it sound good to you?

Bartosz