Re: commit 7ffb791423c7 breaks steam game
From: Ingo Molnar
Date: Thu Mar 27 2025 - 06:41:34 EST
* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 26 Mar 2025 at 15:00, Bert Karwatzki <spasswolf@xxxxxx> wrote:
> >
> > As Balbir Singh found out this memory comes from amdkfd
> > (kgd2kfd_init_zone_device()) with CONFIG_HSA_AMD_SVM=y. The memory gets placed
> > by devm_request_free_mem_region() which places the memory at the end of the
> > physical address space (DIRECT_MAP_PHYSMEM_END). DIRECT_MAP_PHYSMEM_END changes
> > when using nokaslr and so the memory shifts.
>
> So I just want to say that having followed the thread as a spectator,
> big kudos to everybody involved in this thing. Particularly to you,
> Bart, for all your debugging and testing, and to Balbir for following
> up and figuring it out.
>
> Because this was a strange one.
I'd like to second that praise - Bert went above and beyond what could
be expected from or even hoped from someone who reports a regression
that broke his machine. Also, Balbir diligently followed down the
regression to a root cause that was far away from his original code of
interest. It was nice to lurk in this thread.
Thanks,
Ingo