Re: [PATCH v2 3/3] nvme/ioctl: move fixed buffer lookup to nvme_uring_cmd_io()
From: Christoph Hellwig
Date: Thu Mar 27 2025 - 06:45:57 EST
On Fri, Mar 21, 2025 at 02:57:22PM -0600, Caleb Sander Mateos wrote:
> nvme_map_user_request() is called from both nvme_submit_user_cmd() and
> nvme_uring_cmd_io(). But the ioucmd branch is only applicable to
> nvme_uring_cmd_io(). Move it to nvme_uring_cmd_io() and just pass the
> resulting iov_iter to nvme_map_user_request().
>From a quick looks this valid, but actually adds slightly more code.
Is there some long term plan you have in this area that this helps
with? Otherwise it feels like churn.