Re: [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors

[Andy Shevchenko]

On Thu, Mar 27, 2025 at 08:49:45AM +0800, Peng Fan (OSS) wrote:

> Update the driver to fetch buck_gpio and buck_ds as GPIO descriptors.
> Then drop the usage of 'of_gpio.h' which should be deprecated.
> Based on commit 84618d5e31cf ("regulator: max8997:
> Convert to GPIO descriptors") as a reference to make the changes.
> 
> With the quirk fix for s5m8767 in of_gpio_try_fixup_polarity,
> the polarity will be active-high, even if exynos5250 spring DTS
> wrongly use active-low polarity. So using GPIO descriptors,
> it should work as before.

I was a bit trapped by the set_low and set_high callback implementation,
but I think I understood the idea behind and this code does not change
the original logic.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko