Re: [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged_block

[Chi Zhiling]

On 2025/3/27 18:35, Christoph Hellwig wrote:
> On Thu, Mar 27, 2025 at 01:57:06PM +0800, Chi Zhiling wrote:
> > From: Chi Zhiling <chizhiling@xxxxxxxxxx>
> >
> > This renames iomap_last_written_block() to iomap_first_unchanged_block()
> > to better reflect its actual behavior of finding the first unmodified
> > block after partial writes, improving code readability.
>
> Does it?  I it used in the context of a write operation where uncached
> is not exactly well define.  I'm not a native speaker, but I don't see
> an improvement here (then again I picked the current name, so I might be
> biassed).

Okay, actually 'last_written_block' also makes sense, it's just that it 
returns the end of the last written block, not the beginning


thanks,
Chi Zhiling