Re: [PATCH v2 2/4] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to LCD panel
From: Christopher Obbard
Date: Thu Mar 27 2025 - 09:21:38 EST
Hi Abel,
On Thu, 27 Mar 2025 at 07:51, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote:
>
> On 25-03-25 19:21:27, Christopher Obbard wrote:
> > The eDP panel has an HPD GPIO. Describe it in the devicetree.
> >
> > Unfortunately I cannot test this on the non-OLED model since I
> > only have access to the model with OLED (which also uses the
> > HPD GPIO).
> >
> > I believe this could be split into two patches; one adding the
> > pinctrl node and one adding the hpd gpio to the T14s devicetree.
> > But I will wait for your comments on this ;-).
>
> You should definitely drop these two paragraphs entirely from the commit
> message. Maybe add them to the cover letter.
Of course; I will do so in v3.
But hey, it made you both reply, so in a way my comment did work ;-).
Cheers!
Chris