Re: [PATCH] arm64: dts: imx8mp: Add device tree for Nitrogen8M Plus ENC Carrier Board

[Martyn Welch]

 ---- On Thu, 27 Mar 2025 13:00:13 +0000  Daniel Baluta <daniel.baluta@xxxxxxxxx> wrote --- 
 > > +       mdio {
 > > +               compatible = "snps,dwmac-mdio";
 > > +               #address-cells = <1>;
 > > +               #size-cells = <0>;
 > > +
 > > +               ethphy0: ethernet-phy@4 {
 > > +                       compatible = "ethernet-phy-ieee802.3-c22";
 > > +                       reg = <4>;
 > > +                       eee-broken-1000t;
 > > +#if 0
 > > +                       interrupts-extended = <&gpio3 2 IRQ_TYPE_LEVEL_LOW>;
 > > +                       reset-gpios = <&gpio3 16 GPIO_ACTIVE_LOW>;
 > > +#endif
 > 
 > You should not have dead code in the final submission. If it is not
 > used just remove it.
 > 

Agh! Scanned though it a few times, somehow missed the ifdefs. Yup. wIll remove.

Thanks,

Martyn