Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)

[Jürgen Groß]

On 27.03.25 15:13, Borislav Petkov wrote:
> On Wed, Jul 24, 2024 at 11:55:39AM +0200, Jürgen Groß wrote:
> > I'd prefer a general way to handle this problem, like e.g. some kind of
> > __refdata tagging for percpu variables.
>
> Any reason for not doing the trivial thing?
>
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index 10c660fae8b3..100bfaba3f4d 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -53,7 +53,7 @@ struct mc_debug_data {
>   };
>   
>   static DEFINE_PER_CPU(struct mc_buffer, mc_buffer);
> -static struct mc_debug_data mc_debug_data_early __initdata;
> +static struct mc_debug_data mc_debug_data_early;
>   static DEFINE_PER_CPU(struct mc_debug_data *, mc_debug_data) =
>   	&mc_debug_data_early;
>   static struct mc_debug_data __percpu *mc_debug_data_ptr;

Well, that is wasting nearly 3kB of the data section.

Maybe not a big deal, but still...


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature