Re: [xen-tip:linux-next 12/12] WARNING: modpost: vmlinux: section mismatch in reference: mc_debug_data+0x0 (section: .data) -> mc_debug_data_early (section: .init.data)

From: Jürgen Groß
Date: Thu Mar 27 2025 - 11:15:32 EST


On 27.03.25 15:40, Borislav Petkov wrote:
On Thu, Mar 27, 2025 at 03:21:45PM +0100, Jürgen Groß wrote:
Well, that is wasting nearly 3kB of the data section.

Maybe not a big deal, but still...

We could do it until the proper fix is in place, no?

3K is meh, especially for the hypervisor kernel, I'd say...


Yeah, that was my thinking.

Another approach could be to have:

-static DEFINE_PER_CPU(struct mc_debug_data *, mc_debug_data) =
- &mc_debug_data_early;
+static DEFINE_PER_CPU(struct mc_debug_data *, mc_debug_data);

and to use an inline access function returning &mc_debug_data_early
if the percpu variable is NULL. This access function could be __ref.

It is a debug feature after all, so having a few additional instructions
isn't the end of the world.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature