Re: [PATCH v3] iio: frequency: ad9832: Use FIELD_PREP macro to set bit fields
From: Jonathan Cameron
Date: Thu Mar 27 2025 - 11:27:09 EST
> > + phase_cmd = (i % 2 == 0) ? AD9832_CMD_PHA8BITSW : AD9832_CMD_PHA16BITSW;
> > +
> > + st->phase_data[i] = cpu_to_be16(FIELD_PREP(AD9832_CMD_MSK, phase_cmd) |
> > + FIELD_PREP(AD9832_ADD_MSK, addr - i) |
> > + FIELD_PREP(AD9832_DAT_MSK, phase_bytes[i]));
> Would suggest to align with the first cpu_to_be16 argument here too, but better
> wait for Jonathan's opinion about this.
I'd typically go for one tab as done here.