Re: [PATCH v8 02/16] PCI/AER: Modify AER driver logging to report CXL or PCIe bus error type

[Bowman, Terry]

On 3/27/2025 11:58 AM, Ira Weiny wrote:
> Terry Bowman wrote:
>> The AER service driver and aer_event tracing currently log 'PCIe Bus Type'
>> for all errors. Update the driver and aer_event tracing to log 'CXL Bus
>> Type' for CXL device errors.
>>
>> This requires the AER can identify and distinguish between PCIe errors and
>> CXL errors.
>>
>> Introduce boolean 'is_cxl' to 'struct aer_err_info'. Add assignment in
>> aer_get_device_error_info() and pci_print_aer().
>>
>> Update the aer_event trace routine to accept a bus type string parameter.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
> I'm unsure how Karolina's new populate_aer_err_info() will get the new
> is_cxl flag.[1]

It looks like the Karolina's patchset and this will likely fall into the
same merge window. I will need to take a closer look and possibly make changes
for a simpler merge.

> Generally though this looks ok.
>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> [1] https://lore.kernel.org/all/81c040d54209627de2d8b150822636b415834c7f.1742900213.git.karolina.stolarek@xxxxxxxxxx/
>
> [snip]
Thanks Ira.