Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS Vivobook 14 X1404VAP

[Rafael J. Wysocki]

On Wed, Mar 19, 2025 at 1:50 PM Anton Shyndin <mrcold.il@xxxxxxxxx> wrote:
>
> Tested-by: Anton Shyndin <mrcold.il@xxxxxxxxx>
>
> On Tue, Mar 18, 2025 at 6:09 PM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
> >
> > Like the ASUS Vivobook X1504VAP and Vivobook X1704VAP, the ASUS Vivobook 14
> > X1404VAP has its keyboard IRQ (1) described as ActiveLow in the DSDT, which
> > the kernel overrides to EdgeHigh breaking the keyboard.
> >
> >     $ sudo dmidecode
> >     […]
> >     System Information
> >             Manufacturer: ASUSTeK COMPUTER INC.
> >             Product Name: ASUS Vivobook 14 X1404VAP_X1404VA
> >     […]
> >     $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1
> >                  IRQ (Level, ActiveLow, Exclusive, )
> >                      {1}
> >
> > Add the X1404VAP to the irq1_level_low_skip_override[] quirk table to fix
> > this.
> >
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224
> > Cc: Anton Shyndin <mrcold.il@xxxxxxxxx>
> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Cc: All applicable <stable@xxxxxxxxxxxxxxx>
> > Signed-off-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> > ---
> >  drivers/acpi/resource.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> > index b4cd14e7fa76..14c7bac4100b 100644
> > --- a/drivers/acpi/resource.c
> > +++ b/drivers/acpi/resource.c
> > @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
> >                         DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> >                 },
> >         },
> > +       {
> > +               /* Asus Vivobook X1404VAP */
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > +                       DMI_MATCH(DMI_BOARD_NAME, "X1404VAP"),
> > +               },
> > +       },
> >         {
> >                 /* Asus Vivobook X1504VAP */
> >                 .matches = {
> > --

Applied as 6.15-rc material, thanks!