Re: [PATCH v3] drm/panel/sharp-ls043t1le01: Use _multi variants

[Doug Anderson]

Hi,

On Wed, Mar 26, 2025 at 8:29 PM Anusha Srivatsa <asrivats@xxxxxxxxxx> wrote:
>
> Move away from using deprecated API and use _multi variants
> if available. Use mipi_dsi_msleep() and mipi_dsi_usleep_range()
> instead of msleep() and usleep_range() respectively.
>
> Used Coccinelle to find the _multi variant APIs,replacing
> mpi_dsi_msleep() where necessary and for returning
> dsi_ctx.accum_err in these functions. mipi_dsi_dcs_write()
> does not have a corresponding _multi() variant. Replacing it with
> mipi_dsi_dcs_write_seq_multi() instead. This change is manual.
>
> The Coccinelle script is the same as the one in commit c8ba07caaecc
> ("drm/panel/synaptics-r63353: Use _multi variants")
>
> v2: Use mipi_dsi_write_buffer_multi() in place of
> mipi_dsi_dcs_write(). (Dmitry)
>
> v3: add commit details where the same coccinelle script is
> used and remove the actual script from commit log.
> Use mipi_dsi_dcs_write_seq_multi() for mipi_dsi_dcs_write() (Doug)
>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Cc: Tejas Vipin <tejasvipin76@xxxxxxxxx>
> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Anusha Srivatsa <asrivats@xxxxxxxxxx>
> ---
> Changes in v3:
> - Simplify commit log by adding a reference to a patch that uses the
>   same script.
> - Simplify code by using a helper that doesnt need additional code
>   changes other then using the helper itself.
>
> - Link to v2: https://lore.kernel.org/r/20250324-b4-panel-ls043t1le01-v2-1-e43aedc115be@xxxxxxxxxx
>
> Changes in v2:
> - While mipi_dsi_dcs_write() does not have a corresponding _multi()
>   variant replace it with mipi_dsi_dcs_write_buffer_multi() to have all
>   APIs following _multi() usage for easier error handling
>
> - Link to v1: https://lore.kernel.org/r/20250316-b4-panel-ls043t1le01-v1-1-ee38371b0ba0@xxxxxxxxxx
> ---
>  drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 41 +++++++++----------------
>  1 file changed, 15 insertions(+), 26 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>