Re: WARNING: modpost: vmlinux: section mismatch in reference: mm_cmdline_setup+0x94 (section: .text.unlikely) -> memblock (section: .init.data)

From: Wei Yang
Date: Thu Mar 27 2025 - 20:55:56 EST


On Thu, Mar 27, 2025 at 12:36:24PM -0700, Andrew Morton wrote:
>On Thu, 27 Mar 2025 01:13:12 +0000 Wei Yang <richard.weiyang@xxxxxxxxx> wrote:
>
>> Since it is only used by mmu_init() which is annotated by __init, I think the
>> proper way is to add __init to mm_cmdline_setup.
>>
>>
>> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
>> index 4520c5741579..e98cfaf1c62b 100644
>> --- a/arch/microblaze/mm/init.c
>> +++ b/arch/microblaze/mm/init.c
>> @@ -143,7 +143,7 @@ int page_is_ram(unsigned long pfn)
>> /*
>> * Check for command-line options that affect what MMU_init will do.
>> */
>> -static void mm_cmdline_setup(void)
>> +static void __init mm_cmdline_setup(void)
>> {
>> unsigned long maxmem = 0;
>> char *p = cmd_line;
>
>That's a correct change anyway. Please send along a patch sometime?

Sure.

--
Wei Yang
Help you, Help me