Re: [PATCH v2] phy: can-transceiver: Re-instate "mux-states" property presence check

[Vincent Mailhol]

On 21/03/2025 at 13:18, Vincent Mailhol wrote:
> On 21/03/2025 at 00:15, Geert Uytterhoeven wrote:
>> On the Renesas Gray Hawk Single development board:
>>
>>     can-transceiver-phy can-phy0: /can-phy0: failed to get mux-state (0)
>>
>> "mux-states" is an optional property for CAN transceivers.  However,
>> mux_get() always prints an error message in case of an error, including
>> when the property is not present, confusing the user.
>>
>> Fix this by re-instating the property presence check (this time using
>> the proper API) in a wrapper around devm_mux_state_get().  When the
>> multiplexer subsystem gains support for optional muxes, the wrapper can
>> just be removed.
>>
>> In addition, propagate all real errors upstream, instead of ignoring
>> them.
> 
> I would like to hear Rob's opinion on this. In d02dfd4ceb2e9f34 Rob
> purposely changed the function to ignore errors other than EPROBE_DEFER.
> 
> Right now, I do not see a reason not to propagate the other errors, so
> I am in favor of this roll back. But maybe we are missing something?
> 
> Otherwise, the patch looks good to me. Nice improvement over the v1. I
> will wait for Rob's comment to give my review tag.

One week has gone, and we did not hear back. So let's assume it is OK.

>> Fixes: d02dfd4ceb2e9f34 ("phy: can-transceiver: Drop unnecessary "mux-states" property presence check")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

(...)

Yours sincerely,
Vincent Mailhol