Re: [PATCH] m68k/mvme147: Don't unregister boot console needlessly

[Geert Uytterhoeven]

Hi Finn,

On Thu, 27 Mar 2025 at 23:39, Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> When MACH_IS_MVME147, the boot console calls mvme147_scc_write() to
> generate console output. That will continue to work even after
> debug_cons_nputs() becomes unavailable so there's no need to
> unregister the boot console.
>
> Cc: Daniel Palmer <daniel@xxxxxxxx>
> Fixes: 077b33b9e283 ("m68k: mvme147: Reinstate early console")
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/m68k/kernel/early_printk.c
> +++ b/arch/m68k/kernel/early_printk.c
> @@ -60,7 +60,7 @@ early_param("earlyprintk", setup_early_printk);
>
>  static int __init unregister_early_console(void)
>  {
> -       if (!early_console || MACH_IS_MVME16x)
> +       if (!early_console || MACH_IS_MVME147 || MACH_IS_MVME16x)
>                 return 0;
>
>         return unregister_console(early_console);

Perhaps the whole function and the late_initcall() can just be removed?

When the real console kicks in, it usually replaces the early console
(unless "keep_bootcon" is specified on the kernel command line, which
causes all kernel messages to be printed to both the early and normal
console (and thus may cause duplication, if they are the same device)).

Or does that apply only to earlycon early consoles, and not to
earlyprintk?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds