Re: [PATCH v6 1/2] dt-bindings: iio: light: bh1750: Add reset-gpios property

[Jonathan Cameron]

On Mon, 24 Mar 2025 14:59:19 +0100
Sergio Perez <sergio@xxxxxxxxxxx> wrote:

> Some BH1750 sensors require a hardware reset via GPIO before they can
> be properly detected on the I2C bus. Add a new reset-gpios property
> to the binding to support this functionality.
> 
> The reset-gpios property allows specifying a GPIO that will be toggled
> during driver initialization to reset the sensor.
> 
> Signed-off-by: Sergio Perez <sergio@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Series applied to the testing branch of iio.git. I'll rebase that
on rc1 once available and push out as my togreg branch.

Thanks,

Jonathan

> ---
> Revision history:
> v5 => v6:
>  - Fixed include placement as commented by Krzysztof Kozlowski
> v4 => v5:
>  - Update description to reflect "active low" on reset signal as indicated by Krzysztof Kozlowski
>  - Update description to clarify what pin of sensor is used to do reset (DVI) as mentioned by Krzysztof Kozlowski
>  - Edit example to be coherent with "active low" as informed by Krzysztof Kozlowski
>  - Added necessary include on example
> v3 => v4:
>  - No changes
> v2 => v3:
>  - Split in two patches: dtbinding and code
>  - Ensure list off mantainers following instructions by Krzysztof Kozlowski
>  - Delete redundant details on description as suggested by Jonathan Cameron
>  - Added related example to existing one as suggested by Jonathan Cameron
> v1 => v2:
>  - Ensure check tests as commented by Rob Herring
>  - Fixes some whitespaces and end lines
> ---
>  Documentation/devicetree/bindings/iio/light/bh1750.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.yaml b/Documentation/devicetree/bindings/iio/light/bh1750.yaml
> index 1a88b3c253d5..9df81c271411 100644
> --- a/Documentation/devicetree/bindings/iio/light/bh1750.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/bh1750.yaml
> @@ -24,6 +24,10 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  reset-gpios:
> +    description: GPIO connected to the DVI reset pin (active low)
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> @@ -32,6 +36,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/gpio/gpio.h>
>      i2c {
>        #address-cells = <1>;
>        #size-cells = <0>;
> @@ -39,6 +44,7 @@ examples:
>        light-sensor@23 {
>          compatible = "rohm,bh1750";
>          reg = <0x23>;
> +        reset-gpios = <&gpio2 17 GPIO_ACTIVE_LOW>;
>        };
>      };
>