Re: [PATCH v6 4/4] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2025-03-28 06:53:02, "Guenter Roeck" <linux@xxxxxxxxxxxx> wrote:
>On 3/27/25 06:18, Wenliang Yan wrote:
>> Add the sq52206 compatible to the ina2xx.yaml
>> 
>> Signed-off-by: Wenliang Yan <wenliang202407@xxxxxxx>
>> ---
>> 
>> Add the meaning of 'shunt-gain' in SQ52206.
>> 
>> v5->v6:add content to meet the update requirements of the ina2xx.yaml
>> 
>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> index bc03781342c0..8cd672e6bf62 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> @@ -19,6 +19,7 @@ description: |
>>   properties:
>>     compatible:
>>       enum:
>> +      - silergy,sq52206
>>         - silergy,sy24655
>>         - ti,ina209
>>         - ti,ina219
>> @@ -58,6 +59,9 @@ properties:
>>         shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider
>>         voltage range is used.
>>   
>> +      For SQ52206,the shunt-gain value 1 mapps to ADCRANGE=10/11, the value 2
>> +      mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00.
>> +
>>         The default value is device dependent, and is defined by the reset value
>>         of PGA/ADCRANGE in the respective configuration registers.
>>       $ref: /schemas/types.yaml#/definitions/uint32
>> @@ -97,6 +101,7 @@ allOf:
>>           compatible:
>>             contains:
>>               enum:
>> +              - silergy,sy24655
>
>silergy,sq52206 ?
>

Yes, it is my oversight, which may be the reason why 'make dt_binding_check' fails 

>>                 - silergy,sy24655
>>                 - ti,ina209
>>                 - ti,ina219

Thanks,
Wenliang Yan