Re: [PATCH] iomap: Fix conflicting values of iomap flags
From: Christoph Hellwig
Date: Fri Mar 28 2025 - 06:49:24 EST
On Thu, Mar 27, 2025 at 10:04:14PM +0000, John Garry wrote:
> Just my opinion - and others will prob disagree - but I think that the
> reason this was missed (my fault, though) was because we have separate
> grouping of flags within the same struct member. Maybe having separate
> flags altogether would help avoid this.
Yes. But going down to less than 16 bit fields also has downsides, as
does growing the struture.