Re: [PATCH 2/3] rust: dma: convert the read/write macros to return Result

From: Abdiel Janulgue
Date: Fri Mar 28 2025 - 07:17:20 EST




On 26/03/2025 22:48, Miguel Ojeda wrote:
On Wed, Mar 26, 2025 at 9:13 PM Abdiel Janulgue
<abdiel.janulgue@xxxxxxxxx> wrote:

As suggested by Andreas Hindborg, we could do better here by
having the macros return `Result`, so that we don't have to wrap
these calls in a closure for validation which is confusing.

Signed-off-by: Abdiel Janulgue <abdiel.janulgue@xxxxxxxxx>

I would suggest:

Suggested-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
Link: https://lore.kernel.org/rust-for-linux/87h63qhz4q.fsf@xxxxxxxxxx/

Maybe also consider if Co-developed-by etc. makes sense since he
provided the diff.

Thanks! Andreas, would you be okay if I add the Co-developed-by tag?

Regards,
Abdiel