Re: [PATCH] RDMA/mlx5: hide unused code
From: Arnd Bergmann
Date: Fri Mar 28 2025 - 09:21:01 EST
On Fri, Mar 28, 2025, at 14:15, Jason Gunthorpe wrote:
> On Fri, Mar 28, 2025 at 02:10:17PM +0100, Arnd Bergmann wrote:
>
> IDK, I'm tempted to revert 36e0d433672f ("RDMA/mlx5: Compile fs.c
> regardless of INFINIBAND_USER_ACCESS config")
>
> I don't think that was so well thought out. The entire file was
> designed to be USER_ACCESS only because it uses all this mechanism.
>
> #ifdefing away half the file seems ugly.
That sounds better to me, yes. I assumed that a later patch
required that one, but I don't see such a dependency.
Arnd