RE: [PATCH] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller

[Mahapatra, Amit Kumar]

[AMD Official Use Only - AMD Internal Distribution Only]

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Wednesday, March 26, 2025 5:51 PM
> To: Mahapatra, Amit Kumar <amit.kumar-mahapatra@xxxxxxx>;
> broonie@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx
> Cc: linux-spi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>;
> amitrkcian2002@xxxxxxxxx
> Subject: Re: [PATCH] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of
> resets for Cadence OSPI controller
>
> On 26/03/2025 12:37, Amit Kumar Mahapatra wrote:
> > The Cadence Octal SPI (OSPI) controller on AMD Versal SoCs requires
> > only one reset entry. To reflect this, the maxItems for "resets" and
> > "reset-names" has been set to 1 for AMD Versal SoCs, and the minItems
> > for these properties has also been updated to 1. Additionally, these
> > properties have been added to the required property list for Versal SoCs.
> >
> > Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@xxxxxxx>
> > ---
> > BRANCH: mtd/next
> > ---
> >  .../devicetree/bindings/spi/cdns,qspi-nor.yaml     | 14 ++++++++++++--
> >  1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> > b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> > index d48ecd6cd5ad..cc94c59280a1 100644
> > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> > @@ -17,8 +17,18 @@ allOf:
> >            contains:
> >              const: xlnx,versal-ospi-1.0
> >      then:
> > +      properties:
> > +        resets:
> > +          maxItems: 1
> > +
> > +        reset-names:
> > +          maxItems: 1
> > +          items:
> > +            enum: [ qspi ]
>
> Just list the items instead of these three lines.

Do you mean something like this?
        reset-names:
          items:
            - const: [ qspi ]
>
> >        required:
> >          - power-domains
> > +        - resets
> > +        - reset-names
>
> Why? That's an ABI break.

Went through the driver, and believe these properties do not need to be in
the required list. I will revert this change in my next series.
>
>
> >    - if:
> >        properties:
> >          compatible:
> > @@ -132,11 +142,11 @@ properties:
> >      maxItems: 1
> >
> >    resets:
> > -    minItems: 2
> > +    minItems: 1
>
> You need to update other variants now.

Are you referring to other SoCs when you mention other variants?

Regards,
Amit
>
> Best regards,
> Krzysztof