Re: [PATCH v2 2/3] i3c: master: Add Qualcomm I3C controller driver

[Mukesh Kumar Savaliya]

Thanks Markus for review and suggestion !

On 3/28/2025 6:49 PM, Markus Elfring wrote:
> …
> > +++ b/drivers/i3c/master/qcom-i3c-master.c
> > @@ -0,0 +1,1107 @@
> …
> > +static void geni_i3c_abort_xfer(struct geni_i3c_dev *gi3c)
> > +{
> …
> > +	spin_lock_irqsave(&gi3c->irq_lock, flags);
> > +	geni_i3c_handle_err(gi3c, GENI_TIMEOUT);
> > +	geni_se_abort_m_cmd(&gi3c->se);
> > +	spin_unlock_irqrestore(&gi3c->irq_lock, flags);
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&gi3c->irq_lock);”?
Didn't get, hence a question.  Do you suggest to use DEFINE_LOCK_GUARD_1 
instead of existing method ?
> https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/spinlock.h#L572
>
> Regards,
> Markus