Re: [PATCH v3 5/8] arm64: dts: freescale: add Ka-Ro Electronics tx8p-ml81 COMy

[Frank Li]

On Fri, Mar 28, 2025 at 10:43:44AM +0000, Maud Spierings | GOcontroll wrote:
> From: Maud Spierings | GOcontroll <maudspierings@xxxxxxxxxxxxxx>
> Sent: Friday, March 28, 2025 8:20 AM
>
> > From: Frank Li <Frank.li@xxxxxxx>
> > Sent: Thursday, March 27, 2025 5:18 PM
> >
> >> On Thu, Mar 27, 2025 at 04:52:40PM +0100, Maud Spierings via B4 Relay wrote:
> >>> From: Maud Spierings <maudspierings@xxxxxxxxxxxxxx>
> >>>
> >>> The Ka-Ro Electronics tx8p-ml81 is a COM based on the imx8mp SOC. It has
> >>> 2 GB or ram and 8 GB of eMMC storage on board.
> >>>
> >>> Add it to enable boards based on this Module
> >>>
> >>> Signed-off-by: Maud Spierings <maudspierings@xxxxxxxxxxxxxx>
> >>> ---
> >>>  .../arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi | 549 +++++++++++++++++++++
> >>>  1 file changed, 549 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi
> >>> new file mode 100644
> >>> index 0000000000000000000000000000000000000000..9c4304e909b96afeb62962198da377319eda8506
> >>> --- /dev/null
> >>
> >> New dts files, suggest run https://github.com/lznuaa/dt-format to make
> >> nodes and property ordered.
> >
> > Ah I didn't know there is a tool for that, never seen it before, will
> > check it out.
>
> I checked it out but I have one question, this tool orders all nodes
> alphabetically, which is correct. But from what I've seen all imx
> devicetrees have the iomuxc node at the bottom, regardless whether it
> should be there alphabetically. Should I still keep the iomuxc node at the
> bottom?

Old dts iomux is bottom. But I think there should not such requirement now.

Frank

>
> Kind regards,
> Maud