[PATCH v2 0/1] rust: macros: Fix macro referencing core and kernel crates v2
From: Igor Korotin
Date: Fri Mar 28 2025 - 14:24:24 EST
> > To prevent issues where user-defined modules named `core` or `kernel`
> > could be picked up instead of the standard ones, update macros to use
> > absolute paths, `::core::...` and `::kernel::...`, for core and kernel
> > references.
>
> Please split this sentence up into smaller parts. Also "standard ones"
> sounds weird to me, `core` and `kernel` are crates and not modules.
Simplified the commit message.
> > Suggested-by: y86-dev <y86-dev@xxxxxxxxxxxxxx>
>
> Please use my real name and other mail address instead:
>
> Benno Lossin <benno.lossin@xxxxxxxxx>
Sure. Tried to find your creds via your github profile/commits without
success.
> > Closes: https://github.com/Rust-for-Linux/linux/issues/1150
> > Signed-off-by: Igor Korotin <igor.korotin@xxxxxxxxx>
> > ---
> > rust/ffi.rs | 2 +-
> > rust/kernel/device.rs | 2 +-
> > rust/kernel/device_id.rs | 4 ++--
> > rust/kernel/kunit.rs | 8 ++++----
> > rust/kernel/static_assert.rs | 4 ++--
> > rust/kernel/str.rs | 4 ++--
> > rust/macros/lib.rs | 6 +++---
> > scripts/rustdoc_test_gen.rs | 8 ++++++--
> > 8 files changed, 21 insertions(+), 17 deletions(-)
>
> There are also some occurrences of `kernel::` & `core::` in proc macros,
> for example:
> - rust/macros/kunit.rs:129
> - rust/macros/module.rs:347
> - ...
>
> Could you also add those to the patch? Thanks!
>
> (line numbers after applying your patch to rust-next)
Agreed. Fixed references in auto-generated code in files
1. rust/macros/kunit.rs
2. rust/macros/module.rs
3. scripts/rustdoc_test_builder.rs
4. scripts/rustdoc_test_gen.rs
--
2.43.0