Re: [PATCH 0/5] Minor ublk optimizations

From: Jens Axboe
Date: Fri Mar 28 2025 - 15:21:12 EST


On 3/28/25 12:04 PM, Caleb Sander Mateos wrote:
> A few cleanups on top of Ming's recent patch set that implemented
> ->queue_rqs() for ublk:
> https://lore.kernel.org/linux-block/20250327095123.179113-1-ming.lei@xxxxxxxxxx/T/#u
>
> Caleb Sander Mateos (5):
> ublk: remove unused cmd argument to ublk_dispatch_req()
> ublk: skip 1 NULL check in ublk_cmd_list_tw_cb() loop
> ublk: get ubq from pdu in ublk_cmd_list_tw_cb()
> ublk: avoid redundant io->cmd in ublk_queue_cmd_list()
> ublk: store req in ublk_uring_cmd_pdu for ublk_cmd_tw_cb()

All look like reasonable cleanups to me.

--
Jens Axboe