Re: [BUG -next] ./usr/include/cxl/features.h:11:10: fatal error: uuid/uuid.h: No such file or directory

[Dan Williams]

Paul E. McKenney wrote:
> On Fri, Mar 28, 2025 at 04:26:21PM -0700, Dan Williams wrote:
> > Paul E. McKenney wrote:
> > [..]
> > > > > Making the above change got me this:
> > > > > 
> > > > > usr/include/cxl/features.h:59:9: error: unknown type name ‘uuid_t’
> > > > I wasn't able to hit that with allmodconfig on x86 with a Fedora 41 build setup. What is the specific command lines you are using?
> > > 
> > > make clean
> > > make allmodconfig
> > > make -j$N
> > > 
> > > Though encapsulated as follows:
> > > 
> > > tools/testing/selftests/rcutorture/bin/torture.sh --do-none --do-allmodconfig
> > 
> > The problem is that uuid_t is not defined for uapi headers to reuse.
> > Perhaps checkpatch should be checking for uuid_t in uapi headers going
> > forward.
> 
> And for whatever it is worth, "git bisect" converged here:
> 
> 9b8e73cdb141 cxl: Move cxl feature command structs to user header

That makes sense because that was the point at which the usage of uuid_t
in those data structures became invalid.

I am going to have a firm talking to whomever added their Reviewed-by to
that... cue Michael Jackson's "I'm looking at the man in the mirror".

> > For now the following builds for me, but it is a quite a mess to undo
> > the assumption that that the hardware object definitions can not use
> > uuid_t:
> 
> Even better, this builds fine for me:
> 
> Tested-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> 
> Thank you both!

Thanks for the bisect Paul!