Re: [PATCH 2/2] dt-bindings: mailbox: Add devicetree binding for bcm74110 mbox

[Krzysztof Kozlowski]

On 28/03/2025 19:36, Justin Chen wrote:
>>> +    const: 2
>>> +    description:
>>> +      The first cell is channel type and second cell is shared memory slot
>>> +
>>> +  brcm,mbox_tx:
>>
>> No underscores. See DTS coding style.
>>
> 
> Acked. I already had this fixed in the driver, but not in the doc. Woops!

So this did not even work and you did not test DTS.

Where is the DTS?

> 
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: Mailbox transmit doorbell
>>
>> Why is this needed in DT? How many instances do you have in one SoC?
>> Where is the SoC DTS?
>>
> 
> We have 3 possible instances in our current SoC. We currently only 
> implement one. arm,scmi. But more will come in the future. I'll put a 
> sample arm,scmi node as an example consumer in v2.

No. Post your DTS instead.

> 
>>> +
>>> +  brcm,mbox_rx:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: Mailbox receive doorbell
>>> +
>>> +  brcm,mbox_shmem:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +    maxItems: 2
>>> +    description: Mailbox shared memory region and size
>>
>> No, use existing properties, e.g. memory region.
>>
> 
> This is a region from the on chip memory. I will rename to be clear. It 

memory? so reserved region is for what? Not memory?

If this is memory, then reserved region. If this is not memory, but
MMIO, then you have reg for that.


Best regards,
Krzysztof