[PATCH] wifi: iwlwifi: Fix iwl_pci_probe() regression
From: Kurt Borja
Date: Sat Mar 29 2025 - 00:49:17 EST
Fix the following probing error:
iwlwifi: No config found for PCI dev 2725/1674, rev=0x420, rfid=0x10d000
iwlwifi 0000:3b:00.0: probe with driver iwlwifi failed with error -22
Which happens, as the comment suggests, due to an extra `!` when
comparing the device bandwidth with the no_160 subsystem flag.
Fixes: 75a3313f52b7 ("wifi: iwlwifi: make no_160 more generic")
Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
---
Hi all,
After compiling and testing the latest commit on Linus's tree, I found
that my wifi wasn't working. After bisecting I found:
first bad commit: [75a3313f52b7e08e7e73746f69a68c2b7c28bb2b] wifi: iwlwifi: make no_160 more generic
And the culprit was an extra `!` when getting the device info.
This patch is based on the latest commit of Linus's tree.
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index 93446c37400814e2c27ddd2fe93136862fcf4eee..555323341e7d6d7b94e29b4b4530b056bf6433ec 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1449,7 +1449,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
* !bw_limit to have a match.
*/
if (dev_info->bw_limit != IWL_CFG_BW_ANY &&
- (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !!bw_limit)
+ (dev_info->bw_limit == IWL_CFG_BW_NO_LIM) == !bw_limit)
continue;
if (dev_info->cores != (u8)IWL_CFG_ANY &&
---
base-commit: 7d06015d936c861160803e020f68f413b5c3cd9d
change-id: 20250329-wifi-fix-8a4931c06626
Best regards,
--
~ Kurt