Re: [PATCH 1/2] dt-bindings: fpga: zynq: Document ICAP on boot

[Krzysztof Kozlowski]

On 28/03/2025 15:19, Sam Winchenbach wrote:
> From: Sam Winchenbach <swinchenbach@xxxxxxxx>
> 
> Documents the ability to enable the ICAP interface on boot.
> 
> Signed-off-by: Sam Winchenbach <swinchenbach@xxxxxxxx>
> ---
>  .../devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.yaml     | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.yaml
> index 04dcadc2c20e9..bb2781ae126ca 100644
> --- a/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.yaml
> +++ b/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.yaml
> @@ -31,6 +31,13 @@ properties:
>      description:
>        Phandle to syscon block which provide access to SLCR registers
>  
> +  enable-icap-on-load:

Missing vendor prefix.

> +    type: boolean
> +    description: If present, the ICAP controller will be enabled when
> +      the driver probes. This is useful if the fabric is loaded
> +      during the boot process and contains a core, such as the SEM,

I don't get how this is suitable for DT. If you decide to load the
fabric from driver, that's driver decision so not DT.

> +      that requires access to ICAP interface to operate properly.
> +
>  required:
>    - compatible
>    - reg


Best regards,
Krzysztof