Re: [PATCH 1/2] arm64: dts: qcom: sa8775p: add QCrypto node

[Konrad Dybcio]

On 3/28/25 1:48 PM, Dmitry Baryshkov wrote:
> On Fri, Mar 28, 2025 at 11:34:58AM +0530, Yuvaraj Ranganathan wrote:
>>
>>
>> On 3/27/2025 12:38 PM, Krzysztof Kozlowski wrote:
>>> On 26/03/2025 18:40, Yuvaraj Ranganathan wrote:
>>>> On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote:
>>>>> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote:
>>>>>> The initial QCE node change is reverted by the following patch 
>>>>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@xxxxxxxxxx/
>>>>>
>>>>> Use commit SHA syntax (see submitting patches, checkpatch).
>>>>>
>>>>>> because of the build warning,
>>>>>>
>>>>>>   sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed:
>>>>>>     ...
>>>>>>     'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce']
>>>>>
>>>>> Not relevant warning.
>>>>>
>>>>>
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Are you saying this is not the warning seen at merging?
>>> Tell me how it is relevant? Tell me how can I reproduce it.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Below commands will show the above warnings without the fix,
>> make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1
>> make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1
> 
> You are probably running those commands on a tree where the patch was
> not reverted. That's useless. Please update your patches to stop
> mentioning the (outdated) warning and just describe your changes (i.e.
> adding the QCE nodes, you are not fixing any warnings with your change).

(please use linux-next/master unless asked otherwise)

Konrad