RE: [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver for the Renesas RZ/G3E SoC

[John Madieu]

Hi Markus,

Thanks for the feedback.

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@xxxxxx>
> Sent: Saturday, March 29, 2025 2:02 PM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>; linux-renesas-
> soc@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Daniel Lezcano
> <daniel.lezcano@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Rafael J. Wysocki
> <rafael@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>
> Subject: Re: [PATCH v4 3/5] thermal: renesas: rzg3e: Add thermal driver
> for the Renesas RZ/G3E SoC
> 
> …
> > +++ b/drivers/thermal/renesas/rzg3e_thermal.c
> > @@ -0,0 +1,445 @@
> …
> > +static irqreturn_t rzg3e_thermal_adc_irq(int irq, void *dev_id) {
> …
> > +	int new_temp = temp_val * MILLIDEGREE_PER_DEGREE;
> > +
> > +	scoped_guard(spinlock_irqsave, &priv->reg_lock) {
> > +		priv->cached_temp = new_temp;
> > +	}
> > +
> > +	complete(&priv->conv_complete);
> …
> 
> Are curly brackets really relevant for such a “scoped guard”?
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tre
> e/Documentation/process/coding-style.rst?h=v6.14#n197
> 

Will fix it in v5.

> Regards,
> Markus

Regards,
John