Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

From: Willy Tarreau
Date: Sat Mar 29 2025 - 11:51:30 EST


On Fri, Mar 28, 2025 at 04:23:38PM -0600, Shuah Khan wrote:
> On 3/24/25 16:01, Thomas Weißschuh wrote:
> > The include of sys/io.h is not necessary anymore since
> > commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> > It's existence is also problematic as the header does not exist on all
> > architectures.
> >
> > Reported-by: Sebastian Andrzej Siewior <sebastian@xxxxxxxxxxxxx>
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> > index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> > --- a/tools/testing/selftests/nolibc/nolibc-test.c
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -16,7 +16,6 @@
> > #ifndef _NOLIBC_STDIO_H
> > /* standard libcs need more includes */
> > #include <sys/auxv.h>
> > -#include <sys/io.h>
> > #include <sys/ioctl.h>
> > #include <sys/mman.h>
> > #include <sys/mount.h>
> >
> > ---
> > base-commit: bceb73904c855c78402dca94c82915f078f259dd
> > change-id: 20250324-nolibc-ioperm-155646560b95
> >
> > Best regards,
>
> Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

Fine for me as well.

Acked-by: Willy Tarreau <w@xxxxxx>

Thanks,
willy