Re: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT

[Vinod Koul]

On 28-03-25, 14:15, Liao, Bard wrote:
> 
> 
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@xxxxxxxxxx>
> > Sent: Friday, March 28, 2025 9:25 PM
> > To: Liam Girdwood <lgirdwood@xxxxxxxxx>; Peter Ujfalusi
> > <peter.ujfalusi@xxxxxxxxxxxxxxx>; Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>;
> > Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>; Daniel Baluta
> > <daniel.baluta@xxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Jaroslav Kysela
> > <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Vinod Koul
> > <vkoul@xxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>; Kai Vehmanen
> > <kai.vehmanen@xxxxxxxxxxxxxxx>; Pierre-Louis Bossart <pierre-
> > louis.bossart@xxxxxxxxx>; sound-open-firmware@xxxxxxxxxxxxxxxx; linux-
> > sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> > CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> > 
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> > 
> > The newly added driver fails to link without this:
> > 
> > ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > 
> > Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> > BPT DMA")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
> I have the same patch which is pending review/apply.
> https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@xxxxxxxxxxxxxxx/
> I am fine if we go with this patch.
> Acked-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>

I have picked yours as that came first, thanks

-- 
~Vinod