RE: [PATCH 2/2] ACPI: processor: idle: Remove obsolete comment

From: Zhang, Rui
Date: Mon Mar 31 2025 - 03:39:00 EST


> -----Original Message-----
> From: Giovanni Gherdovich <ggherdovich@xxxxxxx>
> Sent: Friday, March 28, 2025 10:31 PM
> To: Rafael J . Wysocki <rafael@xxxxxxxxxx>; Zhang, Rui <rui.zhang@xxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>; Giovanni Gherdovich
> <ggherdovich@xxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx
> Subject: [PATCH 2/2] ACPI: processor: idle: Remove obsolete comment
> Importance: High
>
> Since commit 496121c02127e9c460b436244c38260b044cc45a ("ACPI:
> processor:
> idle: Allow probing on platforms with one ACPI C-state"), the comment
> doesn't reflect the code anymore; remove it.
>
> Signed-off-by: Giovanni Gherdovich <ggherdovich@xxxxxxx>
> ---
> drivers/acpi/processor_idle.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b181f7fc2090..2a076c7a825a 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -482,10 +482,6 @@ static int acpi_processor_get_cstate_info(struct
> acpi_processor *pr)
>
> pr->power.count = acpi_processor_power_verify(pr);
>
> - /*
> - * if one state of type C2 or C3 is available, mark this
> - * CPU as being "idle manageable"
> - */
> for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
> if (pr->power.states[i].valid) {
> pr->power.count = i;
> --
> 2.43.0

I think we can clean up a bit more. How about the patch below?