Re: 答复: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error handle mechanism

[John Garry]

On 31/03/2025 04:10, Jiangjianjun wrote:
> Sorry for late message! I'm working on fixing and testing these issues before re-emailing.

What are you actually working on?

It seems that Hannes' "scsi: EH rework, main part" series and maybe this 
one can help resolve this following issue:

https://lore.kernel.org/linux-block/eef1e927-c9b2-c61d-7f48-92e65d8b0418@xxxxxxxxxx/

with fix attempted in:

https://lore.kernel.org/linux-ide/20241031140731.224589-4-cassel@xxxxxxxxxx/

so that we don't see "fixes" like:
https://lore.kernel.org/linux-scsi/20250329073236.2300582-1-liyihang9@xxxxxxxxxx/T/#m80bcb3f57fd176b7ce41b1f26e8560de6ad52c9d

> -----邮件原件-----
> 发件人: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> 发送时间: 2025年3月20日 14:06
> 收件人: Hannes Reinecke <hare@xxxxxxx>
> 抄送: Jiangjianjun <jiangjianjun3@xxxxxxxxxx>; jejb@xxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; lixiaokeng <lixiaokeng@xxxxxxxxxx>; hewenliang (C) <hewenliang4@xxxxxxxxxx>; Yangkunlin(Poincare) <yangkunlin7@xxxxxxxxxx>
> 主题: Re: [RFC PATCH v3 00/19] scsi: scsi_error: Introduce new error handle mechanism
>
> On Fri, Mar 14, 2025 at 10:01:40AM +0100, Hannes Reinecke wrote:
> > 3. The current EH framework is designed around 'struct scsi_cmnd'.
> > Which means that the command _initiating_ the error handling can only
> > be returned once the _entire_ error handling (with all
> > escalations) is finished. And more often than not, the application is
> > waiting on that command to be completed before the next I/O is sent.
> > And that really limits the effectiveness of any improved error
> > handler; the application ultimatively has to wait for a host reset
> > before it can contine.
>
> And someone needs to get your old series to fix that merged before we even start talking about any major EH change.