Re: [PATCH 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer

[Daniel Lezcano]

On 29/03/2025 18:12, Rob Herring wrote:
> On Fri, Mar 28, 2025 at 08:37:03PM -0500, Rob Herring (Arm) wrote:
> > On Fri, 28 Mar 2025 16:15:13 +0100, Daniel Lezcano wrote:
> > > Describe the Software Watchdog Timer available on the S32G platforms.
> > >
> > > Cc: Ghennadi Procopciuc <ghennadi.procopciuc@xxxxxxx>
> > > Cc: Thomas Fossati <thomas.fossati@xxxxxxxxxx>
> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > > ---
> > >   .../bindings/watchdog/nxp,s32g-wdt.yaml       | 46 +++++++++++++++++++
> > >   1 file changed, 46 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.yaml
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.example.dts:18.29-23.11: Warning (unit_address_format): /example-0/watchdog@0x40100000: unit name should not have leading "0x"
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/nxp,s32g-wdt.example.dtb: watchdog@0x40100000: 'timeout-sec' does not match any of the regexes: 'pinctrl-[0-9]+'
> > 	from schema $id: http://devicetree.org/schemas/watchdog/nxp,s32g-wdt.yaml#
>
> You need unevaluatedProperties instead of additionalProperties.

Thanks!

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog