Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns()

[Ivan Abramov]

On Thu, 27 Mar 2025 19:30:02 -0700, Kuniyuki Iwashima wrote:
> From: Ivan Abramov <i.abramov@xxxxxxxxxxxxxxxxx>
> Date: Fri, 28 Mar 2025 04:04:26 +0300
>> It's pointless to call WARN_ON() in case of an allocation failure in
>> dev_change_net_namespace() and device_rename(), since it only leads to
>> useless splats caused by deliberate fault injections, so avoid it.
>> 
>> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>> 
>> Fixes: 66e5c2672cd1 ("ieee802154: add netns support")
>> Suggested-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
>
> I suggested using net_warn_ratelimited() so this tag is not needed.
> The patch itself looks good to me:

Should I send v2 series with fixed tags?

Thank you for reviewing the series!


> Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
>
>
>> Signed-off-by: Ivan Abramov <i.abramov@xxxxxxxxxxxxxxxxx>
>
> Reported-by: syzbot+e0bd4e4815a910c0daa8@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://lore.kernel.org/netdev/000000000000f4a1b7061f9421de@xxxxxxxxxx/#t

-- 
Ivan Abramov <i.abramov@xxxxxxxxxxxxxxxxx>