RE: [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning
From: Korenblit, Miriam Rachel
Date: Mon Mar 31 2025 - 06:25:22 EST
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Friday, 21 March 2025 16:36
> To: Anjaneyulu, Pagadala Yesu <pagadala.yesu.anjaneyulu@xxxxxxxxx>
> Cc: Korenblit, Miriam Rachel <miriam.rachel.korenblit@xxxxxxxxx>; Berg,
> Johannes <johannes.berg@xxxxxxxxx>; Berg, Benjamin
> <benjamin.berg@xxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning
>
> The "resp_len" isn't initliazed if iwl_dhc_resp_data() fails.
>
> Fixes: b611cf6b57a8 ("wifi: iwlwifi: mld: add support for
> DHC_TOOLS_UMAC_GET_TAS_STATUS command")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/net/wireless/intel/iwlwifi/mld/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> index 453ce2ba39d1..89d95e9b4f30 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> @@ -396,8 +396,8 @@ static ssize_t iwl_dbgfs_tas_get_status_read(struct
> iwl_mld *mld, char *buf,
> .data[0] = &cmd,
> };
> struct iwl_dhc_tas_status_resp *resp = NULL;
> + u32 resp_len = 0;
> ssize_t pos = 0;
> - u32 resp_len;
> u32 status;
> int ret;
>
> --
> 2.47.2
Acked-by: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>