Re: [PATCH 7/9] x86/nmi: Improve NMI header documentation

From: Ingo Molnar
Date: Mon Mar 31 2025 - 06:48:08 EST



* Sohil Mehta <sohil.mehta@xxxxxxxxx> wrote:

> diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
> index 213cf5379a5a..36698cc9fb44 100644
> --- a/arch/x86/include/asm/x86_init.h
> +++ b/arch/x86/include/asm/x86_init.h
> @@ -292,6 +292,7 @@ struct x86_hyper_runtime {
> * @set_wallclock: set time back to HW clock
> * @is_untracked_pat_range exclude from PAT logic
> * @nmi_init enable NMI on cpus
> + * @get_nmi_reason get the reason an NMI was received
> * @save_sched_clock_state: save state for sched_clock() on suspend
> * @restore_sched_clock_state: restore state for sched_clock() on resume
> * @apic_post_init: adjust apic if needed

Note that I've split off this second half into a separate commit:

x86/nmi: Add missing description x86_hyper_runtime::get_nmi_reason to <asm/x86_init.h>

as it's basically an independent KernelDoc bugfix AFAICS.

Thanks,

Ingo