Re: [PATCH v2 1/1] arm64: dts: qcom: x1e80100-dell-xps-9345: Add WiFi/BT pwrseq

[Johan Hovold]

On Mon, Mar 31, 2025 at 11:38:25AM +0200, Aleksandrs Vinarskis wrote:
> On Mon, 31 Mar 2025 at 10:09, Johan Hovold <johan@xxxxxxxxxx> wrote:
> >
> > [ +CC: Stephan ]
> >
> > On Mon, Mar 31, 2025 at 08:33:47AM +0100, Aleksandrs Vinarskis wrote:
> > > Add the WiFi/BT nodes for XPS and describe the regulators for the WCN7850
> > > combo chip using the new power sequencing bindings. All voltages are
> > > derived from chained fixed regulators controlled using a single GPIO.
> > >
> > > Based on the commit d09ab685a8f5 ("arm64: dts: qcom: x1e80100-qcp: Add
> > > WiFi/BT pwrseq").
> >
> > Are you sure this is correct and that you don't need to worry about the
> > "how do we model the supplies to an M.2 card" issue?
> >
> > See
> >
> >         https://lore.kernel.org/lkml/Z-KuG0aOwEnxuhp9@xxxxxxxxxx/
> 
> Dell XPS 9345 does not have an M.2 card, WLAN package is soldered
> directly onboard, hence I am quite sure this is similar to QCP.
> To be certain, perhaps @Tudor, Laurentiu or @Bryan O'Donoghue (if  you
> have it?) could confirm from schematics?

I checked now, it seems you are correct.

Highly annoying that we need all this guess-work boiler plate (about
chip internal details) for what is effectively just two supplies.

Hopefully we can drop that again going forward, but that's a separate
discussion.

> > > With that fixed commit f5b788d0e8cd ("arm64: dts: qcom: Add support for
> > > X1-based Dell XPS 13 9345")
> >
> > Not sure what happened here.
> 
> Bluetooth and WLAN definitions were missing, as at the time I only
> knew the UART port being used for bluetooth, and was missing
> everything else to describe it.

Ah, ok. The above sentence looked like some left-over copy paste. I
guess you don't need to mention it at all since this does not seem to
warrant a proper Fixes tag.

Johan