Re: [PATCH v1 1/1] media: i2c: rdacm2x: Make use of device properties

[Andy Shevchenko]

On Mon, Mar 31, 2025 at 03:07:48PM +0300, Laurent Pinchart wrote:
> On Mon, Mar 31, 2025 at 09:16:36AM +0100, Kieran Bingham wrote:
> > Quoting Andy Shevchenko (2025-03-31 08:34:35)
> > > Convert the module to be property provider agnostic and allow
> > > it to be used on non-OF platforms.
> > 
> > Looks reasonable to me.
> 
> Is that going to work out of the box though ? The calls below read the
> "reg" property to get the device I2C addresses. AFAIK, ACPI handles I2C
> addresses using ACPI-specific methods.
> 
> Andy, have you tested this patch on an ACPI system ?

Only compile-tested. But you are right, this is something different here
between OF and ACPI.

I can rephrase the commit message to just point out that fwnode.h shouldn't
be in the drivers and either converting to device property in an assumption
that later it can be easier to support non-OF cases, or using of.h.

-- 
With Best Regards,
Andy Shevchenko