Re: [PATCH v1 1/1] hwmon: (qnap-mcu) Remove (explicitly) unused header
From: Guenter Roeck
Date: Mon Mar 31 2025 - 09:54:16 EST
On Mon, Mar 31, 2025 at 10:06:00AM +0300, Andy Shevchenko wrote:
> The fwnode.h is not supposed to be used by the drivers as it
> has the definitions for the core parts for different device
> property provider implementations. Drop it.
>
> Note, that fwnode API for drivers is provided in property.h
> which is included here.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/qnap-mcu-hwmon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/qnap-mcu-hwmon.c b/drivers/hwmon/qnap-mcu-hwmon.c
> index 29057514739c..e86e64c4d391 100644
> --- a/drivers/hwmon/qnap-mcu-hwmon.c
> +++ b/drivers/hwmon/qnap-mcu-hwmon.c
> @@ -6,7 +6,6 @@
> * Copyright (C) 2024 Heiko Stuebner <heiko@xxxxxxxxx>
> */
>
> -#include <linux/fwnode.h>
> #include <linux/hwmon.h>
> #include <linux/mfd/qnap-mcu.h>
> #include <linux/module.h>