Re: [PATCH v2 13/16] x86/resctrl: Add code to display core telemetry events

[Reinette Chatre]

Hi Tony,

(nit: "Add code to" can be dropped from shortlog)

On 3/21/25 4:16 PM, Tony Luck wrote:
> These can be read from any CPU. Rely on the smp_call*() functions
> picking the current CPU when given a free choice from cpu_online_mask.
> 
> There may be multiple devices tracking each package, so scan all of them
> and add up counters.
> 
> Output format depends on the data type. Either a 63 bit integer, or a
> fixed point decimal.
> 

At this point the architecture and fs code is very intertwined. I hope that
some of the items I mentioned in earlier patches will help to support a clear
separation that will make the code that follows from here on easier to split
between arch and fs. 
For example, I think this may end up with the new event enums defined in
include/linux/resctrl_types.h to support new architectural helpers
that take the enum as argument that the fs code can use to request the
event value from the architecture. 

Reinette