Re: [PATCH v2 1/1] arm64: dts: qcom: x1e80100-dell-xps-9345: Add WiFi/BT pwrseq

[Johan Hovold]

On Mon, Mar 31, 2025 at 06:51:03PM +0200, Aleksandrs Vinarskis wrote:
> On Mon, 31 Mar 2025 at 13:00, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > On Mon, Mar 31, 2025 at 11:38:25AM +0200, Aleksandrs Vinarskis wrote:
> > > On Mon, 31 Mar 2025 at 10:09, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > > > On Mon, Mar 31, 2025 at 08:33:47AM +0100, Aleksandrs Vinarskis wrote:
> > > > > Add the WiFi/BT nodes for XPS and describe the regulators for the WCN7850
> > > > > combo chip using the new power sequencing bindings. All voltages are
> > > > > derived from chained fixed regulators controlled using a single GPIO.
> > > > >
> > > > > Based on the commit d09ab685a8f5 ("arm64: dts: qcom: x1e80100-qcp: Add
> > > > > WiFi/BT pwrseq").

> > > > > With that fixed commit f5b788d0e8cd ("arm64: dts: qcom: Add support for
> > > > > X1-based Dell XPS 13 9345")
> > > >
> > > > Not sure what happened here.
> > >
> > > Bluetooth and WLAN definitions were missing, as at the time I only
> > > knew the UART port being used for bluetooth, and was missing
> > > everything else to describe it.
> >
> > Ah, ok. The above sentence looked like some left-over copy paste. I
> > guess you don't need to mention it at all since this does not seem to
> > warrant a proper Fixes tag.
> 
> It was a suggestion from Dmitry in v1. Though indeed it does not
> warrant a proper Fixed tag, as it is something  that was left out from
> the initial series, I think it's fine to keep it like this, if it's
> okay with you?

I think you misinterpreted Dmitry here. He just said that after you
added the reference to the commit you based this on to the commit
message you could add his reviewed-by tag ("With that fixed: R-B: Dmitry
...")

	https://lore.kernel.org/all/ou7w4hvbbz72nzrm45gfhpq2uzkuwpfudqeh2o34tcnbnazxgz@glmuryu5dh3s/

As it stands it's hard to understand what that sentence means and why
it is there (looks like a copy paste mistake). I suggest you just drop
it.

Johan