Re: [PATCH v2] media: i2c: Add OV05C10 camera sensor driver

[Nirujogi, Pratap]

Hi Bryan,

Thanks for the review.

Thanks,
Pratap

On 3/28/2025 9:18 PM, Bryan O'Donoghue wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
>
>
> On 28/03/2025 21:42, Pratap Nirujogi wrote:
> > From: Bin Du <Bin.Du@xxxxxxx>
>
> > +static const struct i2c_device_id ov05c10_id[] = {
> > +     {"ov05c10", 0 },
> > +     { }
> > +};
>
> There's an IPU6/IPU7 version of this driver.
>
> https://github.com/intel/ipu6-drivers/blob/master/drivers/media/i2c/ 
> ov05c10.c
>
> Perhaps you could import the Intel ACPI name contained in there too.
sure, will add Intel ACPI names too in V3. To be specific, I'm going to 
add the below table in addition to the existing "struct i2c_device_id 
ov05c10_id[]" table:

static const struct acpi_device_id ov05c10_acpi_ids[] = {
	{ "OVTI05C1" },
	{}
};

> > +
> > +MODULE_DEVICE_TABLE(i2c, ov05c10_id);
> > +
> > +static struct i2c_driver ov05c10_i2c_driver = {
> > +     .driver = {
> > +             .name = DRV_NAME,
> > +             .pm = pm_ptr(&ov05c10_pm_ops),
> > +     },
> > +     .id_table = ov05c10_id,
> > +     .probe = ov05c10_probe,
> > +     .remove = ov05c10_remove,
> > +};
> > +
> > +module_i2c_driver(ov05c10_i2c_driver);
> > +
> > +MODULE_AUTHOR("Pratap Nirujogi <pratap.nirujogi@xxxxxxx>");
> > +MODULE_AUTHOR("Venkata Narendra Kumar Gutta <vengutta@xxxxxxx>");
> > +MODULE_AUTHOR("Bin Du <bin.du@xxxxxxx>");
> > +MODULE_DESCRIPTION("OmniVision OV05C1010 sensor driver");
> > +MODULE_LICENSE("GPL v2");
>
> Why v2 ? Checkpatch will complain about v2 and BTW the IPU6 driver above
> is GPL not GPL v2.
sure, will replace "GPL v2" with "GPL" in V3.

> ---
> bod